linux-kernel - Re: [PATCH] ARM: shmobile: Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUvQNvJhg6u=whYcZCWCnrDJMv=spEw=PBSFe9=jQwhXw@mail.gmail.com>
Date:   Mon, 18 Oct 2021 13:25:37 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Wan Jiabing <wanjiabing@...o.com>
Cc:     Magnus Damm <magnus.damm@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kael_w@...h.net
Subject: Re: [PATCH] ARM: shmobile: Add missing of_node_put()

On Mon, Oct 18, 2021 at 3:45 AM Wan Jiabing <wanjiabing@...o.com> wrote:
> Fix following coccicheck warning:
> ./arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c:156:1-33: Function
> for_each_matching_node_and_match should have of_node_put() before break
> and goto.
>
> Early exits from for_each_matching_node_and_match should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <wanjiabing@...o.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-devel for v5.17.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds