linux-kernel - Re: [PATCH] drm: msm: fix building without CONFIG_COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad5d95ab-7cb5-aef7-9904-eda0befe8519@amd.com>
Date:   Mon, 18 Oct 2021 13:40:54 +0200
From:   Christian König <christian.koenig@....com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...nel.org>, Rob Clark <robdclark@...il.com>,
        Sean Paul <sean@...rly.run>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Arnd Bergmann <arnd@...db.de>,
        Randy Dunlap <rdunlap@...radead.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Alex Elder <elder@...aro.org>,
        Akhil P Oommen <akhilpo@...eaurora.org>,
        Rajeev Nandan <rajeevny@...eaurora.org>,
        Abhinav Kumar <abhinavk@...eaurora.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        freedreno@...ts.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: msm: fix building without CONFIG_COMMON_CLK

Am 18.10.21 um 13:38 schrieb Geert Uytterhoeven:
> Hi Christian,
>
> On Mon, Oct 18, 2021 at 1:37 PM Christian König
> <christian.koenig@....com> wrote:
>> Am 13.10.21 um 16:42 schrieb Arnd Bergmann:
>>> From: Arnd Bergmann <arnd@...db.de>
>>>
>>> When CONFIG_COMMON_CLOCK is disabled, the 8996 specific
>>> phy code is left out, which results in a link failure:
>>>
>>> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg'
>>>
>>> This was only exposed after it became possible to build
>>> test the driver without the clock interfaces.
>>>
>>> Make COMMON_CLK a hard dependency for compile testing,
>>> and simplify it a little based on that.
>>>
>>> Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM")
>>> Reported-by: Randy Dunlap <rdunlap@...radead.org>
>>> Suggested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>> ---
>>>    drivers/gpu/drm/msm/Kconfig  | 2 +-
>>>    drivers/gpu/drm/msm/Makefile | 6 +++---
>>>    2 files changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
>>> index f5107b6ded7b..cb204912e0f4 100644
>>> --- a/drivers/gpu/drm/msm/Kconfig
>>> +++ b/drivers/gpu/drm/msm/Kconfig
>>> @@ -4,8 +4,8 @@ config DRM_MSM
>>>        tristate "MSM DRM"
>>>        depends on DRM
>>>        depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
>>> +     depends on COMMON_CLK
>>>        depends on IOMMU_SUPPORT
>> We also need a "depends on MMU" here because some automated test is now
>> trying to compile the driver on parisc as well.
>>
>> I have absolutely no idea how a platform can have IOMMU but no MMU
>> support but it indeed seems to be the case here.
> Huh?
>
> Parisc has config MMU def_bool y?

Then why vmap isn't available?

See the mail thread: [linux-next:master 3576/7806] 
drivers/gpu/drm/msm/msm_gem.c:624:20: error: implicit declaration of 
function 'vmap'

Thanks for taking a look into this,
Christian.

>
> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds