linux-kernel - [PATCH v11 2/4] drm/bridge: anx7625: fix not correct return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211018030405.2055161-1-xji@analogixsemi.com>
Date:   Mon, 18 Oct 2021 11:04:05 +0800
From:   Xin Ji <xji@...logixsemi.com>
To:     xji@...logixsemi.com
Cc:     Laurent.pinchart@...asonboard.com, a.hajda@...sung.com,
        airlied@...ux.ie, anarsoul@...il.com, bliang@...logixsemi.com,
        boris.brezillon@...labora.com, dan.carpenter@...cle.com,
        daniel@...ll.ch, devel@...verdev.osuosl.org,
        dri-devel@...ts.freedesktop.org, drinkcat@...gle.com, duwe@....de,
        hsinyi@...omium.org, jonas@...boo.se, linux-kernel@...r.kernel.org,
        m.szyprowski@...sung.com, narmstrong@...libre.com,
        robert.foss@...aro.org, sam@...nborg.org, span@...logixsemi.com,
        zhenli@...logixsemi.com
Subject: [PATCH v11 2/4] drm/bridge: anx7625: fix not correct return value

At some time, the original code may return non zero value, force return 0
if operation finished.

Reviewed-by: Robert Foss <robert.foss@...aro.org>
Signed-off-by: Xin Ji <xji@...logixsemi.com>
---
 drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
index 1a871f6b6822..469037f2fd3d 100644
--- a/drivers/gpu/drm/bridge/analogix/anx7625.c
+++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
@@ -191,10 +191,10 @@ static int wait_aux_op_finish(struct anx7625_data *ctx)
 			       AP_AUX_CTRL_STATUS);
 	if (val < 0 || (val & 0x0F)) {
 		DRM_DEV_ERROR(dev, "aux status %02x\n", val);
-		val = -EIO;
+		return -EIO;
 	}
 
-	return val;
+	return 0;
 }
 
 static int anx7625_video_mute_control(struct anx7625_data *ctx,
-- 
2.25.1