[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20211018134844.2627174-1-james.clark@arm.com>
Date: Mon, 18 Oct 2021 14:48:40 +0100
From: James Clark <james.clark@....com>
To: acme@...nel.org, linux-perf-users@...r.kernel.org
Cc: denik@...omium.org, James Clark <james.clark@....com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...hat.com>,
Namhyung Kim <namhyung@...nel.org>,
linux-kernel@...r.kernel.org
Subject: [PATCH 0/3] perf inject: Add vmlinux and ignore-vmlinux arguments
Perf inject was missing the --vmlinux argument so I've added it. At
the same time I tidied up the argument checking that already existed in
perf report and applied it to all tools.
What I'm not sure about is whether it would have been better
to check the accessibility of these files further down in a common place?
It seems like vmlinux_name is also used for a non user provided name at
some point so maybe this would be more complicated than just applying the
existing check everywhere.
Thanks
James
James Clark (3):
perf tools: Refactor out kernel symbol argument sanity checking
perf tools: Check vmlinux/kallsyms arguments in all tools
perf inject: Add vmlinux and ignore-vmlinux arguments
tools/perf/builtin-annotate.c | 4 ++++
tools/perf/builtin-c2c.c | 4 ++++
tools/perf/builtin-inject.c | 7 +++++++
tools/perf/builtin-probe.c | 5 +++++
tools/perf/builtin-record.c | 4 ++++
tools/perf/builtin-report.c | 13 ++-----------
tools/perf/builtin-sched.c | 4 ++++
tools/perf/builtin-script.c | 3 +++
tools/perf/builtin-top.c | 4 ++++
tools/perf/util/symbol.c | 22 ++++++++++++++++++++++
tools/perf/util/symbol.h | 2 ++
11 files changed, 61 insertions(+), 11 deletions(-)
--
2.28.0
Powered by blists - more mailing lists