linux-kernel - Re: [PATCH net-next v2] net: marvell: prestera: add firmware v4.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Oct 2021 18:18:53 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "Volodymyr Mytnyk [C]" <vmytnyk@...vell.com>
Cc:     "kuba@...nel.org" <kuba@...nel.org>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        "Vadym Kochan [C]" <vkochan@...vell.com>,
        Yevhen Orlov <yevhen.orlov@...ision.eu>,
        "Taras Chornyi [C]" <tchornyi@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] net: marvell: prestera: add firmware v4.0
 support

> - Major changes have been made to new v4.0 FW ABI to add support of new features,
>   introduce the stability of the FW ABI and ensure better forward compatibility
>   for the future vesrions.

So this point needs bring out in the commit message. You need to
explain why you think you will never need another ABI break. How your
new design allows extensible, what you have fixed in your old design
which has causes two ABI breaks.

Given this is the second time you have broken the ABI, i need
convincing.

> - All current platforms using this driver have dedicated OOB mgmt port, thus the
>   user still be able to do upgrade of the FW. So, no "Bricks in broom closets" :).

So your cabling guidelines suggest a dedicated Ethernet cable from the
broom closet to the NOC for the OOB port? I suspect most users ignore
this, and do management over the network. They only use the OOB port
when they have bricked the device because they installed a kernel
upgrade over the network, without upgrading the firmware.

	Andrew