linux-kernel - Re: [PATCH] scsi: mpt3sas: make mpt3sas_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cdf9d31-cb90-0792-29e8-52339c1e1043@acm.org>
Date:   Tue, 19 Oct 2021 09:36:53 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        sathya.prakash@...adcom.com
Cc:     sreekanth.reddy@...adcom.com,
        suganath-prabu.subramani@...adcom.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, MPT-FusionLinux.pdl@...adcom.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static

On 10/19/21 3:27 AM, Jiapeng Chong wrote:
> From: chongjiapeng <jiapeng.chong@...ux.alibaba.com>
> 
> This symbol is not used outside of mpt3sas_ctl.c, so marks it static.
> 
> Fixes the following sparse warning:
> 
> drivers/scsi/mpt3sas/mpt3sas_ctl.c:3988:18: warning: symbol
> 'mpt3sas_dev_attrs' was not declared. Should it be static?
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Fixes: 1bb3ca27d2ca ("scsi: mpt3sas: Switch to attribute groups")
> Signed-off-by: chongjiapeng <jiapeng.chong@...ux.alibaba.com>
> ---
>   drivers/scsi/mpt3sas/mpt3sas_ctl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> index 0aabc9761be1..05b6c6a073c3 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c
> @@ -3985,7 +3985,7 @@ sas_ncq_prio_enable_store(struct device *dev,
>   }
>   static DEVICE_ATTR_RW(sas_ncq_prio_enable);
>   
> -struct attribute *mpt3sas_dev_attrs[] = {
> +static struct attribute *mpt3sas_dev_attrs[] = {
>   	&dev_attr_sas_address.attr,
>   	&dev_attr_sas_device_handle.attr,
>   	&dev_attr_sas_ncq_prio_supported.attr,
> 

Reviewed-by: Bart Van Assche <bvanassche@....org>