linux-kernel - Re: [PATCH v3 -next 2/2] blk-cgroup: synchoronize blkg creation against policy deactivation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Oct 2021 07:03:13 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     axboe@...nel.dk, paolo.valente@...aro.org,
        avanzini.arianna@...il.com, fchecconi@...il.com,
        cgroups@...r.kernel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com
Subject: Re: [PATCH v3 -next 2/2] blk-cgroup: synchoronize blkg creation
 against policy deactivation

Hello,

Some nitpicks.

On Tue, Oct 19, 2021 at 10:41:32AM +0800, Yu Kuai wrote:
...
> Because blkcg_deactivate_policy() require queue to be freezed, thus grab
                                    ^                   ^        ^
                                    requires            frozen   we can grab

> q_usage_counter to synchoronize blkg_conf_prep() against
> blkcg_deactivate_policy().
...
> +	/*
> +	 * blkcg_deactivate_policy() require queue to be freezed, thus grab
> +	 * q_usage_counter to prevent concurrent with blkcg_deactivate_policy().
> +	 */

Same here.

Looks good otherwise. Please feel free to add

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun