lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 19 Oct 2021 19:48:15 +0100
From:   David Howells <>
To:     Matthew Wilcox <>
        Kent Overstreet <>,,,
        Trond Myklebust <>,
        Anna Schumaker <>,
        Steve French <>,
        Dominique Martinet <>,
        Jeff Layton <>,
        Alexander Viro <>,
        Omar Sandoval <>,
        Linus Torvalds <>,,,,,,
Subject: Re: [PATCH 01/67] mm: Stop filemap_read() from grabbing a superfluous page

Matthew Wilcox <> wrote:

> > +		isize = i_size_read(inode);
> > +		if (unlikely(iocb->ki_pos >= isize))
> > +			goto put_pages;
> > +
> Is there a good reason to assign to isize here?  I'd rather not,
> because it complicates analysis, and a later change might look at
> the isize read here, not realising it was a racy use.  So I'd
> rather see:

If we don't set isize, the loop will never end.  Actually, maybe we can just
break out at that point rather than going to put_pages.


Powered by blists - more mailing lists