linux-kernel - Re: [PATCH] [v2] net: sched: gred: dynamically allocate tc_gred_qopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d49b4b0f-d1d9-fb24-0ffb-660c666c8a28@gmail.com>
Date:   Tue, 19 Oct 2021 15:26:47 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Ahmed S. Darwish" <a.darwish@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Zheng Yongjun <zhengyongjun3@...wei.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Randy Dunlap <rdunlap@...radead.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] net: sched: gred: dynamically allocate
 tc_gred_qopt_offload



On 10/19/21 12:15 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
>  
> @@ -754,6 +759,10 @@ static int gred_init(struct Qdisc *sch, struct nlattr *opt,
>  		sch->limit = qdisc_dev(sch)->tx_queue_len
>  		             * psched_mtu(qdisc_dev(sch));
>  
> +	table->opt = kzalloc(sizeof(table->opt), GFP_KERNEL);

sizeof(*table->opt) ?

> +	if (!table->opt)
> +		return -ENOMEM;
> +
>  	return gred_change_table_def(sch, tb[TCA_GRED_DPS], extack);
>  }
>