linux-kernel - Re: [PATCH -next] memory: tegra20-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46704f75-ce6c-0687-7d50-f3ff27de7baf@canonical.com>
Date:   Tue, 19 Oct 2021 10:40:11 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     thierry.reding@...il.com, jonathanh@...dia.com,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH -next] memory: tegra20-emc: replace
 DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

On 19/10/2021 10:31, Yang Li wrote:
> Fix the following coccicheck warning:
> ./drivers/memory/tegra/tegra20-emc.c:915:0-23: WARNING:
> tegra_emc_debug_max_rate_fops should be defined with
> DEFINE_DEBUGFS_ATTRIBUTE
> ./drivers/memory/tegra/tegra20-emc.c:885:0-23: WARNING:
> tegra_emc_debug_min_rate_fops should be defined with
> DEFINE_DEBUGFS_ATTRIBUTE
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>

Where is the report? If it is not public, it's not reported-by.

> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/memory/tegra/tegra20-emc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

NAK, it's the 6th patch for DEFINE_SIMPLE_ATTRIBUTE in Tegra memory
controller drivers. Several folks from alibaba and zte.com.cn keep
sending patches replacing only one line each time. Leaving all others
not touched.

It's my mistake I actually accepted this, so this ends now.

This is not a warning, this is not a bug. It is rather a coding
convention, so sending such one-by-one is unnecessary churn. Pointless
patches...

Replace all of such patterns or don't send it.

Best regards,
Krzysztof