linux-kernel - Re: [PATCH 0/4] s390: DYNAMIC_FTRACE_WITH_DIRECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211018220652.014c12a0@gandalf.local.home>
Date:   Mon, 18 Oct 2021 22:06:52 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Heiko Carstens <hca@...ux.ibm.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] s390: DYNAMIC_FTRACE_WITH_DIRECT_CALL support

On Wed, 13 Oct 2021 10:48:20 +0200
Heiko Carstens <hca@...ux.ibm.com> wrote:

> On Tue, Oct 12, 2021 at 08:25:14PM +0200, Heiko Carstens wrote:
> > On Tue, Oct 12, 2021 at 07:04:53PM +0200, Jiri Olsa wrote:  
> > > > > See here:
> > > > > 
> > > > >   https://lore.kernel.org/all/20211008091336.33616-1-jolsa@kernel.org/  
> > > > 
> > > > I applied Jiri's patch set and the newly added selftest passes.  
> > > 
> > > nice, could I have your Tested-by? ;-)  
> > 
> > Well, now I added also the missing pieces to ftrace-direct-multi
> > sample module and when loading that and looking into
> > /sys/kernel/debug/tracing/trace it looks like "my_direct_func" gets
> > some random junk as parameter and nothing that could count as "ip".
> > 
> > Will look into that, probably tomorrow.  
> 
> Ok, if I load the correct module, it even works. I had a bug in the
> first version, fixed it, but still loaded the broken module to test
> my changes. Clever me ;)
> 
> So it all works for me.

BTW, in case you need my ack:

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

for the series.

-- Steve