linux-kernel - Re: [PATCH v2] mm: skip current when memcg reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YW6IDchljdzbxvDU@dhcp22.suse.cz>
Date:   Tue, 19 Oct 2021 10:55:41 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Huangzhaoyang <huangzhaoyang@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        Zhaoyang Huang <zhaoyang.huang@...soc.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mm: skip current when memcg reclaim

On Tue 19-10-21 15:29:36, Huangzhaoyang wrote:
> From: Zhaoyang Huang <zhaoyang.huang@...soc.com>
> 
> Reclaiming pages from current LRU will introduce page thrashing during direct
> reclaiming. Have all memory contraint groups steal pages from the processes
> under root(Non-memory sensitive) or other groups with lower thresholds(high
> memory tolerance) or the one totally sleeping(not busy for the time being,
> borrow some pages).With regard to all groups trapping into direct reclaim,
> retry if first round failed and all groups still compete fairly.
> 
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@...soc.com>
> ---
> patch v2: grant current second chance if previous reclaiming failed

It would be really better to wait until a discussion around the previous
version is concluded before posting another one.
Btw. this changelog has some serious gaps in both the problem and
solution description. Please spend some time looking at other changelogs
for MM patches to get some idea about the level of details that we
usually require.

Thanks!
-- 
Michal Hocko
SUSE Labs