linux-kernel - Re: [PATCH binder] binder: remove duplicate include in binder.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YW6L+LkxamhGLwmt@kroah.com>
Date:   Tue, 19 Oct 2021 11:12:24 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     cgel.zte@...il.com
Cc:     arve@...roid.com, tkjos@...roid.com, maco@...roid.com,
        joel@...lfernandes.org, christian@...uner.io, hridya@...gle.com,
        surenb@...gle.com, linux-kernel@...r.kernel.org,
        Ran Jianping <ran.jianping@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH binder] binder: remove duplicate include in binder.c

On Tue, Oct 19, 2021 at 08:04:02AM +0000, cgel.zte@...il.com wrote:
> From: Ran Jianping <ran.jianping@....com.cn>
> 
> 'binder_trace.h' included in 'drivers/android/binder.c'
>  is duplicated.It is also included on the 6026 line.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Ran Jianping <ran.jianping@....com.cn>
> ---
>  drivers/android/binder.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 26382e982c5e..19f6247d33f5 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6023,6 +6023,5 @@ static int __init binder_init(void)
>  device_initcall(binder_init);
>  
>  #define CREATE_TRACE_POINTS
> -#include "binder_trace.h"
>  
>  MODULE_LICENSE("GPL v2");
> -- 
> 2.25.1
> 

Did you build this code after making this change and verify that the
tracepoints still work properly?

Please fix your "robot", it is broken.

greg k-h