linux-kernel - RE: [PATCH -next] rtw89: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68265a886f8f4ce1a4e9b64b4d80b5a8@realtek.com>
Date:   Tue, 19 Oct 2021 09:13:52 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] rtw89: remove unneeded semicolon


> -----Original Message-----
> From: Yang Li <yang.lee@...ux.alibaba.com>
> Sent: Tuesday, October 19, 2021 3:55 PM
> To: davem@...emloft.net
> Cc: kuba@...nel.org; Pkshih <pkshih@...ltek.com>; kvalo@...eaurora.org; linux-wireless@...r.kernel.org;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Yang Li <yang.lee@...ux.alibaba.com>
> Subject: [PATCH -next] rtw89: remove unneeded semicolon
> 
> Eliminate the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtw89/pci.c:1348:2-3: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
> index e973101..2c94762 100644
> --- a/drivers/net/wireless/realtek/rtw89/pci.c
> +++ b/drivers/net/wireless/realtek/rtw89/pci.c
> @@ -1345,7 +1345,7 @@ static int rtw89_pci_check_mdio(struct rtw89_dev *rtwdev, u8 addr, u8 speed, u16
>  	default:
>  		rtw89_err(rtwdev, "[ERR]Error Speed %d!\n", speed);
>  		return -EINVAL;
> -	};
> +	}
>  	rtw89_write16(rtwdev, R_AX_MDIO_CFG, val);
>  	rtw89_write16_set(rtwdev, R_AX_MDIO_CFG, rw_bit);
> 
> --
> 1.8.3.1