linux-kernel - Re: [PATCH] remove duplicate include in mock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <130dcbfd-ee6d-0d9a-602f-1aaca1229099@intel.com>
Date:   Tue, 19 Oct 2021 10:26:36 +0100
From:   Matthew Auld <matthew.auld@...el.com>
To:     cgel.zte@...il.com, jani.nikula@...ux.intel.com
Cc:     joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        airlied@...ux.ie, daniel@...ll.ch,
        thomas.hellstrom@...ux.intel.com, chris@...is-wilson.co.uk,
        maarten.lankhorst@...ux.intel.com, ran.jianping@....com.cn,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] remove duplicate include in mock_region.c

On 19/10/2021 10:02, cgel.zte@...il.com wrote:
> From: Ran Jianping <ran.jianping@....com.cn>
> 
> 'drm/ttm/ttm_placement.h' included in
> 'drivers/gpu/drm/i915/selftests/mock_region.c' is duplicated.
> It is also included on the 9 line.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Ran Jianping <ran.jianping@....com.cn>

Commit tile should ideally be prefixed with 'drm/i915:'.

Can fix up when pushing though. Thanks,
Reviewed-by: Matthew Auld <matthew.auld@...el.com>

> ---
>   drivers/gpu/drm/i915/selftests/mock_region.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/selftests/mock_region.c b/drivers/gpu/drm/i915/selftests/mock_region.c
> index efa86dffe3c6..75793008c4ef 100644
> --- a/drivers/gpu/drm/i915/selftests/mock_region.c
> +++ b/drivers/gpu/drm/i915/selftests/mock_region.c
> @@ -6,8 +6,6 @@
>   #include <drm/ttm/ttm_placement.h>
>   #include <linux/scatterlist.h>
>   
> -#include <drm/ttm/ttm_placement.h>
> -
>   #include "gem/i915_gem_region.h"
>   #include "intel_memory_region.h"
>   #include "intel_region_ttm.h"
>