linux-kernel - Re: [PATCH v2] mtd: spi-nor: hisi-sfc: Remove excessive clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <94539db8-e6d7-fd1e-46f1-af3ff1525685@microchip.com>
Date:   Tue, 19 Oct 2021 10:16:18 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <novikov@...ras.ru>
CC:     <michael@...le.cc>, <p.yadav@...com>, <miquel.raynal@...tlin.com>,
        <richard@....at>, <vigneshr@...com>, <lee.jones@...aro.org>,
        <bianpan2016@....com>, <linux-mtd@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <ldv-project@...uxtesting.org>
Subject: Re: [PATCH v2] mtd: spi-nor: hisi-sfc: Remove excessive
 clk_disable_unprepare()

On 7/9/21 5:45 PM, Evgeny Novikov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> hisi_spi_nor_probe() invokes clk_disable_unprepare() on all paths after
> successful call of clk_prepare_enable(). Besides, the clock is enabled by
> hispi_spi_nor_prep() and disabled by hispi_spi_nor_unprep(). So at remove
> time it is not possible to have the clock enabled. The patch removes
> excessive clk_disable_unprepare() from hisi_spi_nor_remove().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Fixes: e523f11141bd ("mtd: spi-nor: add hisilicon spi-nor flash controller driver")
> Signed-off-by: Evgeny Novikov <novikov@...ras.ru>
> Reviewed-by: Pratyush Yadav <p.yadav@...com>
> ---
> v2: Fix notes from Pratyush Yadav:
>     - Describe better why clock disabling is not necessary at remove time.
>     - Add tag Fixes.
> ---
>  drivers/mtd/spi-nor/controllers/hisi-sfc.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Applied, thanks.