linux-kernel - Re: [PATCH] mmc: winbond: don't build on M68K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrhdkp2W6rPorw+0T_dZkcg6TXFcqB2vrWnnfvwdhpKzw@mail.gmail.com>
Date:   Tue, 19 Oct 2021 12:59:12 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Pierre Ossman <pierre@...man.eu>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k@...ts.linux-m68k.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] mmc: winbond: don't build on M68K

On Sun, 17 Oct 2021 at 19:59, Randy Dunlap <rdunlap@...radead.org> wrote:
>
> The Winbond MMC driver fails to build on ARCH=m68k so prevent
> that build config. Silences these build errors:
>
> ../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
> ../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
>   212 |                 dmaflags = claim_dma_lock();
> ../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
>   215 |                 release_dma_lock(dmaflags);
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Pierre Ossman <pierre@...man.eu>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: linux-mmc@...r.kernel.org
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: linux-m68k@...ts.linux-m68k.org
> Cc: Arnd Bergmann <arnd@...db.de>

Applied for fixes, thanks!

Kind regards
Uffe

> ---
>  drivers/mmc/host/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20211015.orig/drivers/mmc/host/Kconfig
> +++ linux-next-20211015/drivers/mmc/host/Kconfig
> @@ -508,7 +508,7 @@ config MMC_OMAP_HS
>
>  config MMC_WBSD
>         tristate "Winbond W83L51xD SD/MMC Card Interface support"
> -       depends on ISA_DMA_API
> +       depends on ISA_DMA_API && !M68K
>         help
>           This selects the Winbond(R) W83L51xD Secure digital and
>           Multimedia card Interface.