linux-kernel - Re: [PATCH v3 0/5] mmc: sdhci-pci: Remove dead code and deduplicate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFpX8Xh6aZ6aO=CcHYw45aq89oSywZx9tVaq+GOW1HP=aA@mail.gmail.com>
Date:   Tue, 19 Oct 2021 13:36:47 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Eric Biggers <ebiggers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Raul E Rangel <rrangel@...omium.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-mmc <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH v3 0/5] mmc: sdhci-pci: Remove dead code and deduplicate

On Thu, 14 Oct 2021 at 15:26, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> It appears that one of the supported platform magically worked with
> the custom IRQ handler (any hints how?) while having two PCB designs
> with an opposite CD sense level. Quirking it out reveals the code
> duplication and dead code.
>
> Patch 1 is code deduplication to save few LOCs.
> Patch 2-5 are dead code removals.
>
> In v3:
> - dropped the fix as it has been applied (Ulf)
> - added tag (Adrian)
> - elaborated commit IDs with their short descriptions in patch 3 (Adrian)
> - corrected dependency in patch 5 (Adrian)
>
> In v2:
> - redone fix to use ->get_cd() instead of quirks (Adrian)
> - due to above transformed previous clean up to the current patch 2
> - added a new patch, i.e. patch 3
> - added commit IDs to patch 4 (Adrian)
> - mentioned dependencies on previous patches in patch 5 and 6 (Adrian)
>
> Andy Shevchenko (5):
>   mmc: sdhci: Deduplicate sdhci_get_cd_nogpio()
>   mmc: sdhci: Remove unused prototype declaration in the header
>   mmc: sdhci-pci: Remove dead code (struct sdhci_pci_data et al)
>   mmc: sdhci-pci: Remove dead code (cd_gpio, cd_irq et al)
>   mmc: sdhci-pci: Remove dead code (rst_n_gpio et al)
>
>  drivers/mmc/host/Makefile          |   1 -
>  drivers/mmc/host/sdhci-acpi.c      |  14 +--
>  drivers/mmc/host/sdhci-pci-core.c  | 152 +----------------------------
>  drivers/mmc/host/sdhci-pci-data.c  |   6 --
>  drivers/mmc/host/sdhci-pci.h       |   5 -
>  drivers/mmc/host/sdhci.c           |  19 ++++
>  drivers/mmc/host/sdhci.h           |   2 +-
>  include/linux/mmc/sdhci-pci-data.h |  18 ----
>  8 files changed, 26 insertions(+), 191 deletions(-)
>  delete mode 100644 drivers/mmc/host/sdhci-pci-data.c
>  delete mode 100644 include/linux/mmc/sdhci-pci-data.h
>

Applied for next, thanks!

Kind regards
Uffe