linux-kernel - Re: [PATCH] scsi: core: return -ENOMEM on ips_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85c7ad79ae3b99f92a98e08ca30c4a1763dc3517.camel@linux.ibm.com>
Date:   Tue, 19 Oct 2021 07:49:41 -0400
From:   James Bottomley <jejb@...ux.ibm.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        aacraid@...rosemi.com
Cc:     martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: core: return -ENOMEM on ips_init_phase1()
 allocation failure

On Tue, 2021-10-19 at 18:50 +0800, Jiapeng Chong wrote:
> From: chongjiapeng <jiapeng.chong@...ux.alibaba.com>
> 
> Fixes the following smatch warning:
> 
> drivers/scsi/ips.c:6901 ips_init_phase1() warn: returning -1 instead
> of -ENOMEM is sloppy.

Really, like megaraid, it's not.  ips_init_phase1() returns either
Success or -1.  If it returns -1, that gets translated to -ENODEV so,
again, we'd lose this nuanced return completely.

James