linux-kernel - Re: [EXTERNAL] Re: [v3 2/2] ASoC: max98520: add max98520 audio amplifier driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YW6zKsiWPE+xGWTy@sirena.org.uk>
Date:   Tue, 19 Oct 2021 12:59:38 +0100
From:   Mark Brown <broonie@...nel.org>
To:     George Song <George.Song@...imintegrated.com>
Cc:     "lgirdwood@...il.com" <lgirdwood@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "george.song@...log.com" <george.song@...log.com>,
        Ryan Lee <RyanS.Lee@...imintegrated.com>,
        Steve Lee <SteveS.Lee@...imintegrated.com>
Subject: Re: [EXTERNAL] Re: [v3 2/2] ASoC: max98520: add max98520 audio
 amplifier driver

On Tue, Oct 19, 2021 at 07:57:26AM +0000, George Song wrote:

> > > +	/* L/R mix configuration */
> > > +	regmap_write(max98520->regmap, MAX98520_R2043_PCM_RX_SRC1, 0x2);
> > > +
> > > +	regmap_write(max98520->regmap, MAX98520_R2044_PCM_RX_SRC2, 0x10);
> > 
> > These should be exposed to the user, not hard coded - different systems
> > may need different configurations.
> It`s already exposed for 2043 register which is regarding mono mixer for "DAI Sel Mux"
> It will be exposed for 2044 register which is regarding pcm input channel selection to dapm mixer.

Then leave the values at the defaults and let the user select what's
sensible for their system.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)