linux-kernel - Re: [PATCH] pci: pcie-rcar: add regulators support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YW67tsigF89EkDWS@sirena.org.uk>
Date:   Tue, 19 Oct 2021 13:36:06 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Meng Li <Meng.Li@...driver.com>
Cc:     geert+renesas@...der.be, magnus.damm@...il.com, robh+dt@...nel.org,
        marek.vasut+renesas@...il.com, yoshihiro.shimoda.uh@...esas.com,
        lorenzo.pieralisi@....com, kw@...ux.com, bhelgaas@...gle.com,
        lgirdwood@...il.com, linux-renesas-soc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH] pci: pcie-rcar: add regulators support

On Tue, Oct 19, 2021 at 05:58:58PM +0800, Meng Li wrote:

> From: Andrey Gusakov <andrey.gusakov@...entembedded.com>
> 
> Add PCIe regulators for KingFisher board.
> 
> Signed-off-by: Meng Li <Meng.Li@...driver.com>
> ---

You've not provided a Signed-off-by for Andrey, please see
Documentation/process/submitting-patches.rst for details on what this is
and why it's important.

> +	host->pcie3v3 = devm_regulator_get_optional(dev, "pcie3v3");

> +	host->pcie1v8 = devm_regulator_get_optional(dev, "pcie1v8");

Unless PCIe works without these supplies (which are in my understanding
mandatory according to the spec) these should not be optional, this API
is for supplies that may be physically absent.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)