linux-kernel - Re: [PATCH] arch: arm64: dts: Set gpio5-pin9 as input by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <163465455377.2083150.11106861856940757460@Monstersaurus>
Date:   Tue, 19 Oct 2021 15:42:33 +0100
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Meng Li <Meng.Li@...driver.com>, geert+renesas@...der.be,
        magnus.damm@...il.com, robh+dt@...nel.org
Cc:     linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, meng.li@...driver.com
Subject: Re: [PATCH] arch: arm64: dts: Set gpio5-pin9 as input by default

Quoting Meng Li (2021-10-19 10:00:20)
> The gpio5-pin9 is used as the interrupt pin of i2c external
> gpio chip, so set this pin as input by default.

Is a GPIO hog the right way to do this?
Shouldn't the other GPIO chip be modelled in DT and reference the gpio
interrupt line from there in its interrupt property?

I assume by 'external gpio chip' you mean one which is permanantly
attached to the ULCB Kingfisher board, and not a custom addition?

--
Regards
Kieran

> 
> Signed-off-by: Meng Li <Meng.Li@...driver.com>
> ---
>  arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 202177706cde..8986a7e6e099 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -205,6 +205,15 @@
>         };
>  };
>  
> +&gpio5 {
> +       gpio_exp_77_int {
> +               gpio-hog;
> +               gpios = <9 0>;
> +               input;
> +               line-name = "gpio-exp-77-int";
> +       };
> +};
> +
>  &i2c4 {
>         i2cswitch4: i2c-switch@71 {
>                 compatible = "nxp,pca9548";
> -- 
> 2.17.1
>