linux-kernel - Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YW7htMxwcNjZOtJH@kernel.org>
Date:   Tue, 19 Oct 2021 12:18:12 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Andi Kleen <ak@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        John Garry <john.garry@...wei.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        "Paul A . Clarke" <pc@...ibm.com>,
        Riccardo Mancini <rickyman7@...il.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Zhen Lei <thunder.leizhen@...wei.com>,
        ToastC <mrtoastcheng@...il.com>,
        Joakim Zhang <qiangqing.zhang@....com>,
        Felix Fietkau <nbd@....name>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Song Liu <songliubraving@...com>, Fabian Hemmer <copy@...y.sh>,
        Alexander Antonov <alexander.antonov@...ux.intel.com>,
        Nicholas Fraser <nfraser@...eweavers.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Denys Zagorui <dzagorui@...co.com>,
        Wan Jiabing <wanjiabing@...o.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Sumanth Korikkar <sumanthk@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Changbin Du <changbin.du@...el.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Andrew Kilroy <andrew.kilroy@....com>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v2 21/21] perf metric: Allow modifiers on metrics.

Em Tue, Oct 19, 2021 at 12:17:10PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Oct 19, 2021 at 12:13:52PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Tue, Oct 19, 2021 at 12:06:17PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Fri, Oct 15, 2021 at 10:21:32AM -0700, Ian Rogers escreveu:
> > > > By allowing modifiers on metrics we can, for example, gather the
> > > > same metric for kernel and user mode. On a SkylakeX with
> > > > TopDownL1 this gives:
> > > > 
> > > > $ perf stat -M TopDownL1:u,TopDownL1:k -a sleep 2
> > > > 
> > > >  Performance counter stats for 'system wide':
> > > 
> > > Hi Ian, can you please take a look on this? this is on my perf/core
> > > branch.
> > 
> > I processed the first version of this series, reviewed by Andi, can you
> > please submit the diff from one to the other?
> 
> The interdiff from the 21st patch on the first batch versus on the v2
> batch is below, but it doesn't apply to my current perf/core branch,
> lemme push it to tmp.perf/core...

It was there already, what I have locally is what is in tmp.perf/core.
 
> - Arnaldo
> 
> ⬢[acme@...lbox perf]$ interdiff ~/wb/old.patch ~/wb/new.patch
> diff -u b/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> --- b/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -1308,8 +1308,7 @@
>  	int ret;
> 
>  	*out_evlist = NULL;
> -	ret = metricgroup__build_event_string(&events, ids, modifier,
> -					      has_constraint);
> +	ret = metricgroup__build_event_string(&events, ids, has_constraint);
>  	if (ret)
>  		return ret;
> 
> @@ -1324,7 +1323,8 @@
> 
>  		ids__insert(ids->ids, tmp);
>  	}
> -	ret = metricgroup__build_event_string(&events, ids, has_constraint);
> +	ret = metricgroup__build_event_string(&events, ids, modifier,
> +					      has_constraint);
>  	if (ret)
>  		return ret;
> 
> @@ -1568,7 +1568,10 @@
>  				return -ENOMEM;
> 
>  			new_expr->metric_expr = old_expr->metric_expr;
> -			new_expr->metric_name = old_expr->metric_name;
> +			new_expr->metric_name = strdup(old_expr->metric_name);
> +			if (!new_expr->metric_name)
> +				return -ENOMEM;
> +
>  			new_expr->metric_unit = old_expr->metric_unit;
>  			new_expr->runtime = old_expr->runtime;
> 
> ⬢[acme@...lbox perf]$

-- 

- Arnaldo