linux-kernel - Re: [PATCH] [v2] tracing: use %ps format string to print symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0EYcoPYDPa7MJJJB130qcRAqE_RPiJ-Era0O3i2GBNKQ@mail.gmail.com>
Date:   Tue, 19 Oct 2021 17:32:43 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Tom Zanussi <zanussi@...nel.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Hyeonggon Yoo <42.hyeyoo@...il.com>,
        Qiujun Huang <hqjagain@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] [v2] tracing: use %ps format string to print symbols

On Mon, Oct 18, 2021 at 4:42 PM Tom Zanussi <zanussi@...nel.org> wrote:
> On Mon, 2021-10-18 at 15:25 +0200, Arnd Bergmann wrote:

> This looks fine to me, thanks for the patch!
>
> Reviewed-by: Tom Zanussi <zanussi@...nel.org>
> Tested-by: Tom Zanussi <zanussi@...nel.org>

Thanks for testing!

> > -                     seq_printf(m, "%s: [%llx] %-45s", field_name,
> > -                                uval, str);
> > +                     seq_printf(m, "%s: [%llx] %-45ps", field_name,
> > +                                uval, (void *)uval);

This turns out to be still wrong on 32-bit, as 'uval' is a u64 and I
can't cast that to a pointer without a uintptr_t cast first.

I was testing randconfig builds with clang here, and for some reason
that didn't catch the bug, but I found it after going back to gcc testing.

Sending v3 now.

       Arnd