linux-kernel - Re: [PATCH] PCI: cadence: add missing return for plat probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Oct 2021 14:12:53 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Li Chen <lchen@...arella.com>
Cc:     Tom Joseph <tjoseph@...ence.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh@...nel.org>, "kw@...ux.com" <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI: cadence: add missing return for plat probe

On Wed, Oct 20, 2021 at 11:17:51AM +0000, Li Chen wrote:
> Otherwise, the code will continue to error handle,
> which is not excepted.

In subject and commit log:

  PCI: cadence: Add missing return in cdns_plat_pcie_probe()

  When cdns_plat_pcie_probe() succeeds, return success instead of
  falling into the error handling code.

We should have a Fixes: tag here to show where this bug was
introduced.  Look at previous git history to see the format.  Maybe
also a stable tag so this will get backported to stable kernels.

Interesting that nobody noticed such an obvious bug until now.

> Signed-off-by: Li Chen <lchen@...arella.com>
> Signed-off-by: Xuliang Zhang <xlzhanga@...arella.com>

Since the patch was sent by Li, that signoff should be last, per
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v5.14#n365

Reviewed-by: Bjorn Helgaas <bhelgaas@...gle.com>

Thanks for the patch!

> ---
>  drivers/pci/controller/cadence/pcie-cadence-plat.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/controller/cadence/pcie-cadence-plat.c b/drivers/pci/controller/cadence/pcie-cadence-plat.c
> index 5fee0f89ab59..a224afadbcc0 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-plat.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-plat.c
> @@ -127,6 +127,8 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
>  			goto err_init;
>  	}
>  
> +	return 0;
> +
>   err_init:
>   err_get_sync:
>  	pm_runtime_put_sync(dev);
> -- 
> 2.33.0
> 
> **********************************************************************
> This email and attachments contain Ambarella Proprietary and/or Confidential Information and is intended solely for the use of the individual(s) to whom it is addressed. Any unauthorized review, use, disclosure, distribute, copy, or print is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message. Thank you.