linux-kernel - Re: [PATCH v2] nios2: Make NIOS2_DTB_SOURCE_BOOL depend on !COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b747abf-73f1-fa97-cb2b-23d8c838426e@infradead.org>
Date:   Wed, 20 Oct 2021 13:15:46 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Guenter Roeck <linux@...ck-us.net>,
        Dinh Nguyen <dinguyen@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nios2: Make NIOS2_DTB_SOURCE_BOOL depend on
 !COMPILE_TEST

On 10/20/21 12:11 PM, Guenter Roeck wrote:
> nios2:allmodconfig builds fail with
> 
> make[1]: *** No rule to make target 'arch/nios2/boot/dts/""',
> 	needed by 'arch/nios2/boot/dts/built-in.a'.  Stop.
> make: [Makefile:1868: arch/nios2/boot/dts] Error 2 (ignored)
> 
> This is seen with compile tests since those enable NIOS2_DTB_SOURCE_BOOL,
> which in turn enables NIOS2_DTB_SOURCE. This causes the build error
> because the default value for NIOS2_DTB_SOURCE is an empty string.
> Disable NIOS2_DTB_SOURCE_BOOL for compile tests to avoid the error.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Thanks, I've seen this problem also.

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

> ---
> v2: Include error message
> 
>   arch/nios2/platform/Kconfig.platform | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/nios2/platform/Kconfig.platform b/arch/nios2/platform/Kconfig.platform
> index 9e32fb7f3d4c..e849daff6fd1 100644
> --- a/arch/nios2/platform/Kconfig.platform
> +++ b/arch/nios2/platform/Kconfig.platform
> @@ -37,6 +37,7 @@ config NIOS2_DTB_PHYS_ADDR
>   
>   config NIOS2_DTB_SOURCE_BOOL
>   	bool "Compile and link device tree into kernel image"
> +	depends on !COMPILE_TEST
>   	help
>   	  This allows you to specify a dts (device tree source) file
>   	  which will be compiled and linked into the kernel image.
> 


-- 
~Randy