linux-kernel - RE: [PATCH v1 0/2] fpga: dfl: Log and clear errors on driver init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR11MB3819F29DF7B20FDED6DC814685BE9@DM6PR11MB3819.namprd11.prod.outlook.com>
Date:   Wed, 20 Oct 2021 04:44:43 +0000
From:   "Wu, Hao" <hao.wu@...el.com>
To:     "Weight, Russell H" <russell.h.weight@...el.com>,
        "mdf@...nel.org" <mdf@...nel.org>,
        "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "trix@...hat.com" <trix@...hat.com>,
        "lgoncalv@...hat.com" <lgoncalv@...hat.com>,
        "Xu, Yilun" <yilun.xu@...el.com>,
        "Gerlach, Matthew" <matthew.gerlach@...el.com>
Subject: RE: [PATCH v1 0/2] fpga: dfl: Log and clear errors on driver init

> Subject: [PATCH v1 0/2] fpga: dfl: Log and clear errors on driver init
> 
> These patches address a request to log and clear any prexisting errors on
> FPGA cards when the drivers load. Any existing errors will result in print
> statements to the kernel error log before the errors are cleared. These
> changes specifically affect the fme and port error registers.

Could you please explain more about why we need this change? 
As we have user interface to log and clear errors already, is it a better choice
to let userspace log and clear them during AFU initialization?

Hao

> 
> Russ Weight (2):
>   fpga: dfl: afu: Clear port errors in afu init
>   fpga: dfl: fme: Clear fme global errors at driver init
> 
>  drivers/fpga/dfl-afu-error.c |  26 ++++---
>  drivers/fpga/dfl-fme-error.c | 128 +++++++++++++++++++++++------------
>  2 files changed, 100 insertions(+), 54 deletions(-)
> 
> --
> 2.25.1