linux-kernel - Re: [PATCH 1/2] i2c: virtio: disable timeout handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YW+q1yQ8MuhHINAs@kroah.com>
Date:   Wed, 20 Oct 2021 07:36:23 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jie Deng <jie.deng@...el.com>
Cc:     Wolfram Sang <wsa@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Vincent Whitchurch <vincent.whitchurch@...s.com>,
        virtualization@...ts.linux-foundation.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...s.com
Subject: Re: [PATCH 1/2] i2c: virtio: disable timeout handling

On Wed, Oct 20, 2021 at 12:20:13PM +0800, Jie Deng wrote:
> 
> On 2021/10/20 2:14, Wolfram Sang wrote:
> > > I think it is set to HZ currently, though I haven't tried big
> > > transfers but I still get into some issues with Qemu based stuff.
> > > Maybe we can bump it up to few seconds :)
> > If you use adapter->timeout, this can even be set at runtime using a
> > ioctl. So, it can adapt to use cases. Of course, the driver should
> > initialize it to a sane default if the automatic default (HZ) is not
> > suitable.
> 
> 
> I think a big value may solve most cases. but the driver never know how big
> is enough by static configuration.
> 
> Can we make this value to be configurable, just let the other side provide
> this value ?

If an ioctl can change it, that would mean it is configurable, right?