linux-kernel - Re: [PATCH] block: schedule queue restart after BLK_STS_ZONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YW+ySp6Fqgxr8alD@infradead.org>
Date:   Tue, 19 Oct 2021 23:08:10 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Naohiro Aota <naohiro.aota@....com>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: schedule queue restart after BLK_STS_ZONE_RESOURCE

On Wed, Oct 20, 2021 at 01:04:04PM +0900, Naohiro Aota wrote:
>  		needs_restart = blk_mq_sched_needs_restart(hctx);
> +		need_resource |= (prep == PREP_DISPATCH_NO_BUDGET);

Nit: I think this would be a little more readable as:

		if (prep == PREP_DISPATCH_NO_BUDGET)
			need_resource = true;

But otherwise the patch looks good:

Reviewed-by: Christoph Hellwig <hch@....de>