linux-kernel - Re: [PATCH net] rsi: stop thread firstly in rsi_91x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <163471920135.1743.399816436682216881.kvalo@codeaurora.org>
Date:   Wed, 20 Oct 2021 08:40:11 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Ziyang Xuan <william.xuanziyang@...wei.com>
Cc:     <amitkarwar@...il.com>, <siva8118@...il.com>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] rsi: stop thread firstly in rsi_91x_init() error
 handling

Ziyang Xuan <william.xuanziyang@...wei.com> wrote:

> When fail to init coex module, free 'common' and 'adapter' directly, but
> common->tx_thread which will access 'common' and 'adapter' is running at
> the same time. That will trigger the UAF bug.
> 
> ==================================================================
> BUG: KASAN: use-after-free in rsi_tx_scheduler_thread+0x50f/0x520 [rsi_91x]
> Read of size 8 at addr ffff8880076dc000 by task Tx-Thread/124777
> CPU: 0 PID: 124777 Comm: Tx-Thread Not tainted 5.15.0-rc5+ #19
> Call Trace:
>  dump_stack_lvl+0xe2/0x152
>  print_address_description.constprop.0+0x21/0x140
>  ? rsi_tx_scheduler_thread+0x50f/0x520
>  kasan_report.cold+0x7f/0x11b
>  ? rsi_tx_scheduler_thread+0x50f/0x520
>  rsi_tx_scheduler_thread+0x50f/0x520
> ...
> 
> Freed by task 111873:
>  kasan_save_stack+0x1b/0x40
>  kasan_set_track+0x1c/0x30
>  kasan_set_free_info+0x20/0x30
>  __kasan_slab_free+0x109/0x140
>  kfree+0x117/0x4c0
>  rsi_91x_init+0x741/0x8a0 [rsi_91x]
>  rsi_probe+0x9f/0x1750 [rsi_usb]
> 
> Stop thread before free 'common' and 'adapter' to fix it.
> 
> Fixes: 2108df3c4b18 ("rsi: add coex support")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@...wei.com>

Patch applied to wireless-drivers-next.git, thanks.

515e7184bdf0 rsi: stop thread firstly in rsi_91x_init() error handling

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211015040335.1021546-1-william.xuanziyang@huawei.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches