linux-kernel - Re: [PATCH] KVM: cleanup allocation of rmaps and page tracking data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dd914336-efca-e74e-521d-dbf57ad4eba3@redhat.com>
Date:   Wed, 20 Oct 2021 11:21:00 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Maxim Levitsky <mlevitsk@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     seanjc@...gle.com, David Stevens <stevensd@...omium.org>
Subject: Re: [PATCH] KVM: cleanup allocation of rmaps and page tracking data

On 19/10/21 21:28, Maxim Levitsky wrote:
>> +static inline bool kvm_memslots_have_rmaps(struct kvm *kvm)
>> +{
>> +	return !kvm->arch.tdp_mmu_enabled || kvm_shadow_root_alloced(kvm);
>>   }
> Note that this breaks 32 bit build - kvm->arch.tdp_mmu_enabled is not defined.

Indeed, the right test is is_tdp_mmu_enabled(kvm).

Paolo