linux-kernel - Re: [PATCH 1/2] Bluetooth: btrtl: Add support for RTL8822C hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7c0ba739-f2fe-ad09-e3e2-4b1286aabf38@lexina.in>
Date:   Wed, 20 Oct 2021 13:08:06 +0300
From:   Vyacheslav <adeep@...ina.in>
To:     Marcel Holtmann <marcel@...tmann.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
        chbgdn <chbgdn@...il.com>
Subject: Re: [PATCH 1/2] Bluetooth: btrtl: Add support for RTL8822C hci_ver
 0x08

19.10.2021 21:29, Marcel Holtmann wrote:
> Hi Vyacheslav,
> 
>> Add detection of RTL8822CS controller with hci_ver = 0x08
>>
>> Signed-off-by: chbgdn <chbgdn@...il.com>
> 
> clear name please.

If Bohdan doesn't answer, we can remove this line.

>> +	/* 8822C with UART interface */
>> +	{ IC_INFO(RTL_ROM_LMP_8822B, 0xc, 0x8, HCI_UART),
>> +	  .config_needed = true,
>> +	  .has_rom_version = true,
>> +	  .fw_name  = "rtl_bt/rtl8822cs_fw.bin",
>> +	  .cfg_name = "rtl_bt/rtl8822cs_config" },
>> +
> 
> what about the .has_msft_ext here. Does this one support the Microsoft extension?



This is only a variant of the already added 8822c controller, so I 
simply copied the parameters and changed only hci_ver to 0x8.
I found this controller on X96 TV Box and JetHome H1 device.

It will also be necessary to update rtl8822cs_config in the 
linux-firmware repository from 
https://github.com/armbian/firmware/commit/5d685ad233b4dfd03a4d025fa0061f6b0f850cb3