linux-kernel - Re: [PATCH] crash_dump: remove duplicate include in crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211020015357.GD27625@MiWiFi-R3L-srv>
Date:   Wed, 20 Oct 2021 09:53:57 +0800
From:   Baoquan He <bhe@...hat.com>
To:     cgel.zte@...il.com
Cc:     dyoung@...hat.com, vgoyal@...hat.com, kexec@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Ye Guojin <ye.guojin@....com.cn>,
        Zeal Robot <zealci@....com.cn>, rppt@...ux.ibm.com
Subject: Re: [PATCH] crash_dump: remove duplicate include in crash_dump.h

On 10/20/21 at 01:23am, cgel.zte@...il.com wrote:
> From: Ye Guojin <ye.guojin@....com.cn>
> 
> 'linux/pgtable.h' included in 'crash_dump.h' is duplicated.
> it's also included at line 8.

OK, in below commit the including order is adjusted, but the old one was
not removed.
commit 65fddcfca8ad("mm: reorder includes after introduction of linux/pgtable.h")

Could you rephrase the commit log? , the below sentences is for your reference.

============
In crash_dump.h, header file linux/pgtable.h is included twice. This
duplication was introduced in commit 65fddcfca8ad("mm: reorder includes
after introduction of linux/pgtable.h") where the order of include is
adjusted, while the old one was not removed.

Clean it up here.
============

Thanks for fixing this. when you finish polishing the patch log, please
feel free to add:

Acked-by: Baoquan He <bhe@...hat.com>

Thanks
Baoquan

> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Ye Guojin <ye.guojin@....com.cn>
> ---
>  include/linux/crash_dump.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index 0c547d866f1e..b7b255b23b99 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
>  #include <linux/pgtable.h>
>  #include <uapi/linux/vmcore.h>
>  
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
>  /* For IS_ENABLED(CONFIG_CRASH_DUMP) */
>  #define ELFCORE_ADDR_MAX	(-1ULL)
>  #define ELFCORE_ADDR_ERR	(-2ULL)
> -- 
> 2.25.1
>