linux-kernel - Re: [PATCH V3] media: i2c: ccs: replace snprintf in show functions with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YW/7HRMQ1CMY2zNy@paasikivi.fi.intel.com>
Date:   Wed, 20 Oct 2021 14:18:53 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Kieran Bingham <kieran.bingham@...asonboard.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Qing Wang <wangqing@...o.com>, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH V3] media: i2c: ccs: replace snprintf in show functions
 with sysfs_emit

On Wed, Oct 20, 2021 at 10:47:36AM +0100, Kieran Bingham wrote:
> Hi Qing,
> 
> Quoting Qing Wang (2021-10-20 03:14:15)
> > show() should not use snprintf() when formatting the value to be
> > returned to user space.
> > 
> > Fix the following coccicheck warning:
> > drivers/media/i2c/ccs/ccs-core.c:3761: WARNING: use scnprintf or sprintf.
> > 
> > V3:
> > - Fix some formatting problems.
> 
> This could go below the --- so that it doesn't get entered into the
> commit itself, but I suspect that can be handled while applying. Not
> sure what the preferences are for that.

You're right in saying it needs to be after '---' line. But no need to
resend for that.

> 
> Anyway, thank you for updating with my suggestions.
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> 
> > 
> > Signed-off-by: Qing Wang <wangqing@...o.com>
> > ---
> >  drivers/media/i2c/ccs/ccs-core.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
> > index 5363f3b..9158d3c
> > --- a/drivers/media/i2c/ccs/ccs-core.c
> > +++ b/drivers/media/i2c/ccs/ccs-core.c
> > @@ -2758,13 +2758,13 @@ ident_show(struct device *dev, struct device_attribute *attr, char *buf)
> >         struct ccs_module_info *minfo = &sensor->minfo;
> >  
> >         if (minfo->mipi_manufacturer_id)
> > -               return snprintf(buf, PAGE_SIZE, "%4.4x%4.4x%2.2x\n",
> > -                               minfo->mipi_manufacturer_id, minfo->model_id,
> > -                               minfo->revision_number) + 1;
> > +               return sysfs_emit(buf, "%4.4x%4.4x%2.2x\n",
> > +                                 minfo->mipi_manufacturer_id, minfo->model_id,
> > +                                 minfo->revision_number) + 1;
> >         else
> > -               return snprintf(buf, PAGE_SIZE, "%2.2x%4.4x%2.2x\n",
> > -                               minfo->smia_manufacturer_id, minfo->model_id,
> > -                               minfo->revision_number) + 1;
> > +               return sysfs_emit(buf, "%2.2x%4.4x%2.2x\n",
> > +                                 minfo->smia_manufacturer_id, minfo->model_id,
> > +                                 minfo->revision_number) + 1;
> >  }
> >  static DEVICE_ATTR_RO(ident);
> >  
> > -- 
> > 2.7.4
> >

-- 
Sakari Ailus