linux-kernel - Re: [PATCH 0/3] fixes for __airqs_kick_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211020141210.557d4fa8.pasic@linux.ibm.com>
Date:   Wed, 20 Oct 2021 14:12:10 +0200
From:   Halil Pasic <pasic@...ux.ibm.com>
To:     Christian Borntraeger <borntraeger@...ibm.com>
Cc:     Janosch Frank <frankja@...ux.ibm.com>,
        Michael Mueller <mimu@...ux.ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        David Hildenbrand <david@...hat.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Pierre Morel <pmorel@...ux.ibm.com>,
        Tony Krowiak <akrowiak@...ux.ibm.com>,
        Matthew Rosato <mjrosato@...ux.ibm.com>,
        Niklas Schnelle <schnelle@...ux.ibm.com>, farman@...ux.ibm.com,
        kvm@...r.kernel.org, Halil Pasic <pasic@...ux.ibm.com>
Subject: Re: [PATCH 0/3] fixes for __airqs_kick_single_vcpu()

On Wed, 20 Oct 2021 13:04:05 +0200
Christian Borntraeger <borntraeger@...ibm.com> wrote:

> Am 19.10.21 um 19:53 schrieb Halil Pasic:
> > The three fixes aren't closely related. The first one is the
> > most imporant one. They can be picked separately. I deciced to send them
> > out together so that if reviewers see: hey there is more broken, they
> > can also see the fixes near by.
> > 
> > Halil Pasic (3):
> >    KVM: s390: clear kicked_mask before sleeping again
> >    KVM: s390: preserve deliverable_mask in __airqs_kick_single_vcpu
> >    KVM: s390: clear kicked_mask if not idle after set
> > 
> >   arch/s390/kvm/interrupt.c | 12 +++++++++---
> >   arch/s390/kvm/kvm-s390.c  |  3 +--
> >   2 files changed, 10 insertions(+), 5 deletions(-)
> > 
> > 
> > base-commit: 519d81956ee277b4419c723adfb154603c2565ba  
> 
> I picked and queued patches 1 and 2. Thanks a lot for fixing.
> I will need some time to dig through the code to decide about patch3.

Sure. In the meantime I think we can do slightly better for patch 3
by making the clear introduced by patch 1 conditional (in patch 3
as patch 3 makes that a safe move).

Regards,
Halil