[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YXAL7Gc/wGR0Ce3g@sirena.org.uk>
Date: Wed, 20 Oct 2021 13:30:36 +0100
From: Mark Brown <broonie@...nel.org>
To: Lucas Tanure <tanureal@...nsource.cirrus.com>
Cc: Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>,
Len Brown <lenb@...nel.org>,
David Rhodes <david.rhodes@...rus.com>,
Liam Girdwood <lgirdwood@...il.com>,
"Rafael J . Wysocki" <rafael@...nel.org>,
alsa-devel@...a-project.org, linux-acpi@...r.kernel.org,
patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/3] sound: cs35l41: Allow HDA systems to use
CS35l41 ASoC driver
On Wed, Oct 20, 2021 at 09:59:42AM +0100, Lucas Tanure wrote:
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
> Re-use ASoC driver for supporting for Legion 7 16ACHg6
> laptop.
> HDA machine driver will find the registered dais for the
> Amp and use snd_soc_dai_ops to configure it.
It will find the registered DAIs in what way exactly?
This patch is doing a whole bunch of stuff which isn't described at all
in the changelog which makes it very hard to review, I can't tell what
it's supposed to do.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists