linux-kernel - Re: [PATCH v2 04/21] perf pmu: Make pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YXAYkecMsW+Zj8W9@kernel.org>
Date:   Wed, 20 Oct 2021 10:24:33 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     John Garry <john.garry@...wei.com>
Cc:     Ian Rogers <irogers@...gle.com>, Andi Kleen <ak@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Kajol Jain <kjain@...ux.ibm.com>,
        "Paul A . Clarke" <pc@...ibm.com>,
        Riccardo Mancini <rickyman7@...il.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jacob Keller <jacob.e.keller@...el.com>,
        Zhen Lei <thunder.leizhen@...wei.com>,
        ToastC <mrtoastcheng@...il.com>,
        Joakim Zhang <qiangqing.zhang@....com>,
        Felix Fietkau <nbd@....name>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Song Liu <songliubraving@...com>, Fabian Hemmer <copy@...y.sh>,
        Alexander Antonov <alexander.antonov@...ux.intel.com>,
        Nicholas Fraser <nfraser@...eweavers.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Denys Zagorui <dzagorui@...co.com>,
        Wan Jiabing <wanjiabing@...o.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Sumanth Korikkar <sumanthk@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Andrew Kilroy <andrew.kilroy@....com>,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v2 04/21] perf pmu: Make pmu_event tables const.

Em Tue, Oct 19, 2021 at 12:19:24PM +0100, John Garry escreveu:
> On 15/10/2021 18:21, Ian Rogers wrote:

> - bouncing Changbin Du <changbin.du@...el.com> and Jin Yao
> <yao.jin@...ux.intel.com>
 
> > Make lookup nature of data structures clearer through their type. Reduce
> > scope of architecture specific pmu_event tables by making them static.

> > Suggested-by: John Garry<john.garry@...wei.com>
> > Acked-by: Andi Kleen<ak@...ux.intel.com>
> > Signed-off-by: Ian Rogers<irogers@...gle.com>
 
> Reviewed-by: John Garry <john.garry@...wei.com>
 
> BTW, We seem to be using > 80 char per line now. Well in metricgroup.h
> anyway, from a brief check. I know checkpatch.pl is ok with this now, but
> some maintainers aren't. Just saying.

I don't have a problem with that:

[acme@...co ~]$ echo $COLUMNS
273
[acme@...co ~]$

:-)

- Arnaldo