linux-kernel - Re: [PATCH v2 3/5] tracing: Fix operator precedence for hist triggers expression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211020102807.0b07bc81@gandalf.local.home>
Date:   Wed, 20 Oct 2021 10:28:07 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Kalesh Singh <kaleshsingh@...gle.com>
Cc:     surenb@...gle.com, hridya@...gle.com, namhyung@...nel.org,
        kernel-team@...roid.com, Jonathan Corbet <corbet@....net>,
        Ingo Molnar <mingo@...hat.com>, Shuah Khan <shuah@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Tom Zanussi <zanussi@...nel.org>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 3/5] tracing: Fix operator precedence for hist
 triggers expression

On Tue, 19 Oct 2021 18:31:40 -0700
Kalesh Singh <kaleshsingh@...gle.com> wrote:

> +	minus_op = strrchr(str, '-');
> +	if (minus_op) {
> +		/* Unfortunately, the modifier ".sym-offset" can confuse things. */
> +		if (minus_op - str >= 4 && !strncmp(minus_op - 4, ".sym-offset", 11))
> +			goto out;
>  

I was thinking about this, and perhaps we can add this later, but we could
just replace all ".sym-offset" with ".symXoffset" after receiving it from
the user. Then it won't be an issue during prasing.

-- Steve