linux-kernel - Re: [PATCH] kselftests: ftrace: limit the executing time by reading from cached trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211020112027.b01762f2adcfac99e71dcf99@kernel.org>
Date:   Wed, 20 Oct 2021 11:20:27 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Li Zhijian <lizhijian@...fujitsu.com>, <mingo@...hat.com>,
        <shuah@...nel.org>, <linux-kselftest@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Philip Li <philip.li@...el.com>,
        kernel test robot <lkp@...el.com>,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] kselftests: ftrace: limit the executing time by reading
 from cached trace

On Mon, 18 Oct 2021 22:16:36 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Mon, 18 Oct 2021 21:26:16 +0800
> Li Zhijian <lizhijian@...fujitsu.com> wrote:
> 
> > LKP/0day observed that kselftests/ftrace cannot finish within 1 hour on
> > a 96 cpus platform where it hangs in the line like:
> > 'cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l'
> > subsystem-enable.tc
> > 
> > It seems that trace will keep growing during it's read by 'cat' command.
> > Consequently, trace becomes too large to finish reading.
> > 
> > replace 'cat trace' by:
> > $ sed -i 's/cat trace |/read_cached_trace |/g' $(find test.d -name "*.tc")
> > 
> 
> Instead, what happens if you add this command to each test?
> 
> if [ -t options/pause-on-trace ]; then
>    echo 1 > options/pause-on-trace
> fi
> 
> We also need to add to the "initialize_ftrace" function in test.d/functions.
> 
> if [ -t options/pause-on-trace ]; then
>    echo 0 > options/pause-on-trace
> fi

Hmm, by the way, shouldn't we set this feature by default?
There are many "cat trace | grep ..." style test code in ftracetest just for
checking whether the event is recorded. At least for the ftracetest, it should
be set unless the testcase is explicitly disable it.

Thank you.

> 
> -- Steve
> 
> > CC: Philip Li <philip.li@...el.com>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Signed-off-by: Li Zhijian <lizhijian@...fujitsu.com>
> > ---


-- 
Masami Hiramatsu <mhiramat@...nel.org>