linux-kernel - Re: [PATCH 0/2] perf jevents: Enable build warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Oct 2021 15:41:01 +0100
From:   John Garry <john.garry@...wei.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
CC:     <peterz@...radead.org>, <mark.rutland@....com>,
        <alexander.shishkin@...ux.intel.com>, <jolsa@...hat.com>,
        <namhyung@...nel.org>, <mingo@...hat.com>, <irogers@...gle.com>,
        <linux-perf-users@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "James Clark" <James.Clark@....com>
Subject: Re: [PATCH 0/2] perf jevents: Enable build warnings

On 20/10/2021 15:31, Arnaldo Carvalho de Melo wrote:
> Em Sat, Oct 16, 2021 at 12:48:25AM +0800, John Garry escreveu:
>> Currently jevents builds without any complier warning flags enabled. So
>> use newly-defined HOSTCFLAGS, which comes from EXTRA_WARNINGS. I am not
>> 100% confident that this is the best way, but sending out for review.
>>
>> Baseline is be8ecc57f180 (HEAD, acme/perf/core) perf srcline: Use
>> long-running addr2line per DSO
> 
> Thanks, applied.
> 

Hi Arnaldo,

I was going to send a v2, with changes according to James Clark's review 
  - that was to add -Wall & -Werror, but they caused a problem on your 
perf/core branch as they triggered the warn fixed in commit b94729919db2.

I suppose the best thing now is to send a patch on top once perf/core 
contains that commit. Let me know otherwise.

Thanks