linux-kernel - Re: [PATCH v4 1/2] socfpga: dts: move arria10 aliases to socfpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF9_jYQt6ObUcaA0_aKHnQDoKuYPAYT48jfA3_RKE=q1OkCang@mail.gmail.com>
Date:   Wed, 20 Oct 2021 17:52:28 +0200
From:   Paweł Anikiel <pan@...ihalf.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Dinh Nguyen <dinguyen@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Olof Johansson <olof@...om.net>, SoC Team <soc@...nel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        upstream@...ihalf.com, Marcin Wojtas <mw@...ihalf.com>,
        Jacek Majkowski <jam@...ihalf.com>,
        Konrad Adamczyk <ka@...ihalf.com>,
        Tomasz Nowicki <tn@...ihalf.com>,
        Alexandru Stan <amstan@...gle.com>
Subject: Re: [PATCH v4 1/2] socfpga: dts: move arria10 aliases to socfpga_arria10.dtsi

On Wed, Oct 20, 2021 at 3:33 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Tue, Oct 19, 2021 at 4:12 PM Paweł Anikiel <pan@...ihalf.com> wrote:
> >
> > socfpga_arria10_socdk.dtsi declares aliases which will most likely
> > be used by other arria10 boards in the exact same way. move these
> > aliases to the parent file.
> >
> > Signed-off-by: Paweł Anikiel <pan@...ihalf.com>
>
> No, please move them into the .dts files instead for consistency.
>
> Each board may use a different subset of them, or have them
> numbered differently, so keep it out of the .dtsi file.
>
>      Arnd

Thank you for your remark. The aliases per .dts file were in the v3
patch, however this change was explicitly requested. I will bring that
back and resubmit.

Thanks, Paweł.