linux-kernel - Re: [PATCH v2 01/14] objtool: Tag retpoline thunk symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Oct 2021 08:17:14 -0700
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, andrew.cooper3@...rix.com,
        linux-kernel@...r.kernel.org, alexei.starovoitov@...il.com,
        ndesaulniers@...gle.com
Subject: Re: [PATCH v2 01/14] objtool: Tag retpoline thunk symbols

On Wed, Oct 20, 2021 at 12:44:43PM +0200, Peter Zijlstra wrote:
> In order to avoid calling arch_is_retpoline() (which does a strcmp)
> over and over on symbols, tag them once upfront.
> 
> XXX do we also want to do __fentry__ ?

Might as well.

> XXX do we want an enum instead of a bunch of bools ?

Maybe, or convert the bools to bit fields.

-- 
Josh