linux-kernel - Re: [GIT PULL] NIOS2: fix for v5.15, part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wj=eUah6C8Zj4z2OzbFGn0Oxtg9cqvYs1kD-=qPj0dYBw@mail.gmail.com>
Date:   Wed, 20 Oct 2021 06:02:23 -1000
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Dinh Nguyen <dinguyen@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] NIOS2: fix for v5.15, part 2

On Mon, Oct 18, 2021 at 9:59 AM Dinh Nguyen <dinguyen@...nel.org> wrote:
>
> - Renamed CTL_STATUS to CTL_FSTATUS to fix a redefined warning

Hmm. That's still some very generic names exposed in a arch header
file that seems to get included (indirectly) almost everywhere.

I've pulled this, but I would suggest you name those flags not "CTL"
but something that is more exclusive to nios2.

Btw, the same goes for some of the other macros in there that are
currently unique - like "RDCTL". That's a name that I can see a driver
using internally, and with nios2 being so unusual, it would take
potentially a longish time before anybody even noticed.

            Linus