linux-kernel - Re: [PATCH v3 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAN5uoS8V7ygo04iOjb=AF8HLf58cpZkL8QzkaG8kouKtUYS-aw@mail.gmail.com>
Date:   Wed, 20 Oct 2021 18:45:11 +0200
From:   Etienne Carriere <etienne.carriere@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Cristian Marussi <cristian.marussi@....com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Sudeep Holla <sudeep.holla@....com>, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI

Hi again,

On Wed, 20 Oct 2021 at 17:52, Etienne Carriere
<etienne.carriere@...aro.org> wrote:
>
> Hello Rob,
>
>
> On Mon, 18 Oct 2021 at 19:32, Rob Herring <robh@...nel.org> wrote:
> >
> > On Mon, 18 Oct 2021 13:40:45 +0200, Etienne Carriere wrote:
> > > Introduce compatible "linaro,scmi-optee" for SCMI transport channel
> > > based on an OP-TEE service invocation. The compatible mandates a
> > > channel ID defined with property "linaro,optee-channel-id".
> > >
> > > Cc: devicetree@...r.kernel.org
> > > Cc: Rob Herring <robh+dt@...nel.org>
> > > Signed-off-by: Etienne Carriere <etienne.carriere@...aro.org>
> > > ---
> > > Changes since v2:
> > >  - Define mandatory property linaro,optee-channel-id
> > >  - Rebased on yaml description file
> > >
> > > Changes since v1:
> > >  - Removed modification regarding mboxes property description.
> > > ---
> > >  .../bindings/firmware/arm,scmi.yaml           | 44 +++++++++++++++++++
> > >  1 file changed, 44 insertions(+)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: patternProperties:^protocol@[0-9a-f]+$:properties:linaro,optee-channel-id: 'description' is a required property
> >         hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
> >         from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: patternProperties:^protocol@[0-9a-f]+$:properties:linaro,optee-channel-id: 'oneOf' conditional failed, one must be fixed:
> >         'type' is a required property
> >                 hint: A vendor boolean property can use "type: boolean"
> >         Additional properties are not allowed ('maxItems' was unexpected)
> >                 hint: A vendor boolean property can use "type: boolean"
> >         /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: patternProperties:^protocol@[0-9a-f]+$:properties:linaro,optee-channel-id: 'oneOf' conditional failed, one must be fixed:
> >                 'enum' is a required property
> >                 'const' is a required property
> >                 hint: A vendor string property with exact values has an implicit type
> >                 from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
> >         /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: patternProperties:^protocol@[0-9a-f]+$:properties:linaro,optee-channel-id: 'oneOf' conditional failed, one must be fixed:
> >                 '$ref' is a required property
> >                 'allOf' is a required property
> >                 hint: A vendor property needs a $ref to types.yaml
> >                 from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
> >         hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
> >         from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: ignoring, error in schema: patternProperties: ^protocol@[0-9a-f]+$: properties: linaro,optee-channel-id
> > warning: no schema found in file: ./Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> > Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:0:0: /example-1/firmware/scmi: failed to match any schema with compatible: ['arm,scmi']
> > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:175.39-178.19: ERROR (duplicate_label): /example-2/firmware/scmi/protocol@14: Duplicate label 'scmi_clk' on /example-2/firmware/scmi/protocol@14 and /example-0/firmware/scmi/protocol@14
> > Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:180.40-186.19: ERROR (duplicate_label): /example-2/firmware/scmi/protocol@13: Duplicate label 'scmi_dvfs' on /example-2/firmware/scmi/protocol@13 and /example-0/firmware/scmi/protocol@13
> > ERROR: Input tree has errors, aborting (use -f to force output)
> > make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [Makefile:1441: dt_binding_check] Error 2
> >
> > doc reference errors (make refcheckdocs):
> >
> > See https://patchwork.ozlabs.org/patch/1542547
> >
> > This check can fail if there are any dependencies. The base for a patch
> > series is generally the most recent rc1.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit.
> >
>
> Thanks for the feedback and guidelines. I've played a bit with dt
> checker and saw that description/type/etc.. are not needed when the
> property name does not include a coma ','.
>
> I think i'll use "optee-channel-id" instead of
> "linaro,optee-channel-id" as property name.
> With that name, 'make dt_binding_check' passes without complains on
> arm,scmi.yaml.
> I have no strong preference and here and can go either ways.

Discard my comment. I'll preserve the linaro, vendor prefix.
This property is all but generic.
I"ll add a clean description where needed and run dt_checker against.

Sorry for the noise.
Regards,
Etienne


>
> I though the "linaro," was expected.
> Please tell me if there's any reason I need to preserve this "linaro,"
> prefix on that property.
>
> Regards,
> Etienne