linux-kernel - Re: linux-next: Tree for Oct 21 (drivers/irqchip/irq-mchp-eic.o)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r1cebb7x.wl-maz@kernel.org>
Date:   Thu, 21 Oct 2021 17:21:06 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: linux-next: Tree for Oct 21 (drivers/irqchip/irq-mchp-eic.o)

Hi Randy,

On Thu, 21 Oct 2021 16:26:58 +0100,
Randy Dunlap <rdunlap@...radead.org> wrote:
> 
> On 10/21/21 12:43 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20211020:
> > 
> 
> on i386 and x86_64:
> 
> ld: drivers/irqchip/irq-meson-gpio.o:(.data+0x0): undefined reference to `platform_irqchip_probe'
> ld: drivers/irqchip/irq-mchp-eic.o:(.data+0x0): undefined reference to `platform_irqchip_probe'
> 
> Full randconfig file is attached.

Thanks for the heads up. It looks like despite the drivers advertising
being able to compile on all architectures (CONFIG_COMPILE_TEST), they
obviously don't.

I'm going to slap the "fix" below on top of the current tree.

	M.

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 7038957f4a77..77887e2002db 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -407,7 +407,7 @@ config IRQ_UNIPHIER_AIDET
 
 config MESON_IRQ_GPIO
        tristate "Meson GPIO Interrupt Multiplexer"
-       depends on ARCH_MESON || COMPILE_TEST
+       depends on ARCH_MESON
        default ARCH_MESON
        select IRQ_DOMAIN_HIERARCHY
        help
@@ -611,7 +611,7 @@ config APPLE_AIC
 
 config MCHP_EIC
 	bool "Microchip External Interrupt Controller"
-	depends on ARCH_AT91 || COMPILE_TEST
+	depends on ARCH_AT91
 	select IRQ_DOMAIN
 	select IRQ_DOMAIN_HIERARCHY
 	help

-- 
Without deviation from the norm, progress is not possible.