linux-kernel - Re: [PATCH v2 0/2] memblock: exclude MEMBLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Oct 2021 12:52:01 -0400
From:   Qian Cai <quic_qiancai@...cinc.com>
To:     Mike Rapoport <rppt@...nel.org>, <linux-mm@...ck.org>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] memblock: exclude MEMBLOCK_NOMAP regions from
 kmemleak



On 10/21/21 3:09 AM, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@...ux.ibm.com>
> 
> Hi,
> 
> This is take 2 to fix interaction between MEMBLOCK_NOMAP and kmemleak.
> 
> The previous version caused boot failures Qian Cai reported here:
> 
> https://lore.kernel.org/all/c30ff0a2-d196-c50d-22f0-bd50696b1205@quicinc.com
> 
> The failures happened because calling kmemleak_free_part_phys() (or any
> kmemleak phys APIs for that matter) too early means it cannot use __va() on
> arm64.
> 
> This late in the cycle I can only think of reverting kmemleak wavier from
> memblock_mark_nomap() and putting it in the only two callers that set
> MEMBLOCK_NOMAP to an allocated chunk rather than marking NOMAP "unusable"
> memory reported by firmware.
> 
> The first patch here is the revert of v1 and the second patch is actual v2
> implementation.
> 
> Vladimir and Qian, I'd appreciate if you could verify that v2 works for
> you.

FYI, this passed the regression tests here.


> 
> v2:
> * move kmemleak waiver from memblock_mark_nomap() to callers that need it
> * use kmemleak_ignore_phys() rather than kmemleak_free_part_phys() as
>   Catalin suggested.
> 
> v1: https://lore.kernel.org/all/20211013054756.12177-1-rppt@kernel.org
> 
> Mike Rapoport (2):
>   Revert "memblock: exclude NOMAP regions from kmemleak"
>   memblock: exclude MEMBLOCK_NOMAP regions from kmemleak
> 
>  drivers/acpi/tables.c        |  3 +++
>  drivers/of/of_reserved_mem.c |  2 ++
>  mm/memblock.c                | 10 ++++------
>  3 files changed, 9 insertions(+), 6 deletions(-)
> 
> 
> base-commit: 519d81956ee277b4419c723adfb154603c2565ba
>