linux-kernel - Re: [PATCH v1] usb: xhci: tegra: Check padctrl interrupt presence in device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19e852e5-0952-f665-4e0c-627e070f6abf@gmail.com>
Date:   Thu, 21 Oct 2021 22:17:16 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mathias Nyman <mathias.nyman@...el.com>,
        JC Kuo <jckuo@...dia.com>, Nicolas Chauvet <kwizart@...il.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH v1] usb: xhci: tegra: Check padctrl interrupt presence in
 device tree

21.10.2021 22:14, Alan Stern пишет:
...
>>> Should USB keyboard be able to wake up every HC or it's a
>>> machine-specific feature?
>>
>> I mean whether key press should wake up HC if wake-up is enabled for the
>> keyboard device.
> 
> Yes, it should.  More specifically, if the keyboard is capable of 
> generating wakeup requests, and wakeup is enabled for both the keyboard 
> device and the HC, then the keyboard should be able to wake up the 
> system from suspend.  Some HCs or systems might not support this 
> capability, however.
> 
>>> I'm asking because wakeup works on a typical
>>> Intel hardware, but doesn't work on older Tegra SoCs that use Chipidea
>>> controller. It's not obvious to me whether this is something that
>>> firmware handles for Intel or it's broken on Tegra. Could you please
>>> clarify? If it should work for every HC, then I may try to take a closer
>>> look.
> 
> If the hardware/firmware can support it then it should work.  I don't 
> know what's going on with your older Tegra SoCs; it's possible there is 
> a bug in the driver.

I'll take a closer look then, thank you.