linux-kernel - Re: [GIT PULL] tracing: Fix to recursion protection for 5.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgBhyLhQLPem1vybKNt7BKP+=qF=veBgc7VirZaXn4FUw@mail.gmail.com>
Date:   Wed, 20 Oct 2021 20:08:09 -1000
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Petr Mladek <pmladek@...e.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [GIT PULL] tracing: Fix to recursion protection for 5.15

On Wed, Oct 20, 2021 at 12:41 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> I guess I can still automate the Cc's without issue.

I like the cc: lines, and I don't think it's a great argument to say
that "the data is in the thread in the link".

Generally the commit message should stand on its own, and contain
enough of the relevant information that the link data isn't needed.

So _primarily_ the "Link:" line should be about background - and for
"oh, there was discussion about this patch after it was committed".

So it should not be seen as a _replacement_ for any information in the
commit itself, or as an excuse to leave relevant information out.

That said, I'm not entirely convinced that it's useful copying
everybody that was on the cc of the patch - particularly if they never
actually participated in the discussion at all.

But it's probably better to have too many cc's listed in the commit
than too few - at least within reason.

Because if a commit turns out to cause problems, the list of email
addresses mentioned in the commit message should be seen as the
primary list of "hey people, this patch you were involved with has
issues"

           Linus