linux-kernel - Re: [v5 PATCH 3/6] mm: filemap: coding style cleanup for filemap_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fcadd8a722eabf33638a234f3d1cb026977b35df.camel@perches.com>
Date:   Wed, 20 Oct 2021 23:19:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     Yang Shi <shy828301@...il.com>, naoya.horiguchi@....com,
        hughd@...gle.com, kirill.shutemov@...ux.intel.com,
        willy@...radead.org, peterx@...hat.com, osalvador@...e.de,
        akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [v5 PATCH 3/6] mm: filemap: coding style cleanup for
 filemap_map_pmd()

On Wed, 2021-10-20 at 14:07 -0700, Yang Shi wrote:
> A minor cleanup to the indent.
[]
> diff --git a/mm/filemap.c b/mm/filemap.c
[]
> @@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page)
>  	}
>  
>  	if (pmd_none(*vmf->pmd) && PageTransHuge(page)) {
> -	    vm_fault_t ret = do_set_pmd(vmf, page);
> -	    if (!ret) {
> -		    /* The page is mapped successfully, reference consumed. */
> -		    unlock_page(page);
> -		    return true;
> -	    }
> +		vm_fault_t ret = do_set_pmd(vmf, page);
> +		if (!ret) {
> +			/* The page is mapped successfully, reference consumed. */
> +			unlock_page(page);
> +			return true;
> +		}

It might be more preferred to add a blank line after the automatic
when touching this block.