linux-kernel - Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in tegra_adma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0f51171-2a8b-b931-eb98-63e92fdf9dee@nvidia.com>
Date:   Thu, 21 Oct 2021 07:58:53 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Dongliang Mu <mudongliangabcd@...il.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Vinod Koul <vkoul@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>
CC:     <dmaengine@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: tegra210-adma: fix pm runtime unbalance in
 tegra_adma_remove


On 21/10/2021 04:14, Dongliang Mu wrote:
> Since pm_runtime_put is done when tegra_adma_probe is successful, we
> cannot do pm_runtime_put_sync again in tegra_adma_remove.
> 
> Fix this by removing the pm_runtime_put_sync in tegra_adma_remove.
> 
> Signed-off-by: Dongliang Mu <mudongliangabcd@...il.com>
> ---
>   drivers/dma/tegra210-adma.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> index b1115a6d1935..7e4d40cd9577 100644
> --- a/drivers/dma/tegra210-adma.c
> +++ b/drivers/dma/tegra210-adma.c
> @@ -940,7 +940,6 @@ static int tegra_adma_remove(struct platform_device *pdev)
>   	for (i = 0; i < tdma->nr_channels; ++i)
>   		irq_dispose_mapping(tdma->channels[i].irq);
>   
> -	pm_runtime_put_sync(&pdev->dev);
>   	pm_runtime_disable(&pdev->dev);
>   
>   	return 0;
> 

Thanks!

Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Jon

-- 
nvpublic